ListView_Basic.tBasic

[DirectuX]

Hi,

again If I'm not mistaken,
you may want to change these lines in ListView_Basic.tBasic sample:

line 263 :

Log_AddMessage hDlg, "Command", ListView_GetItemText(hDlg, hCtrl), "%CMD_SelectAll"
to
Log_AddMessage hDlg, ("Command", ListView_GetItemText(hDlg, hCtrl), "%CMD_SelectAll")

line 271 :

Log_AddMessage hDlg, "Command", ListView_GetItemText(hDlg, hCtrl), "%CMD_SelectItem"
to
Log_AddMessage hDlg, ("Command", ListView_GetItemText(hDlg, hCtrl), "%CMD_SelectItem")

line 281 :

Log_AddMessage hDlg, "Command", ListView_GetItemText(hDlg, hCtrl), "%CMD_FILE_MODIFY"
to
Log_AddMessage hDlg, ("Command", ListView_GetItemText(hDlg, hCtrl), "%CMD_FILE_MODIFY")

[ErosOlmi]

Yes you are right.
Thanks

We have a so many examples, sometimes specifications change and examples remain ... old or buggy.

[Petr Schreiber]

Eros,

what about putting SampleScripts on gitHub, so users can help with the issues if they know how to fix it via pull request?

The installation preparation process could fetch the latest version from there.

Benefits? Currently, you have to do all the changes AND/OR accept the changes via email / private messages.
The gitHub way could still give us option to decide whether to accept or reject the change, and there would be a place where the latest version is always present.

I would create how to article for users not knowing gitHub, to make it easier to understand the mechanisms of contribution and reduce the learning curve angle.


Just an idea,
Petr