Page 2 of 2 FirstFirst 12
Results 11 to 15 of 15

Thread: cVec thinBasic math vector class

  1. #11
    thinBasic MVPs Michael Hartlef's Avatar
    Join Date
    Sep 2006
    Location
    Germany
    Age
    58
    Posts
    3,299
    Rep Power
    348
    Yes, I noticed it too with Github, sometimes you need to wait a little. The changes don't show up right away.

  2. #12
    Super Moderator Petr Schreiber's Avatar
    Join Date
    Aug 2005
    Location
    Brno - Czech Republic
    Posts
    7,153
    Rep Power
    736
    I get the same "changed" state with vec3, even in its reborn form. Pure. Mystery

    I could give pull request to normalize it my way... but then I wonder what happens to Kent


    Petr
    Learn 3D graphics with ThinBASIC, learn TBGL!
    Windows 10 64bit - Intel Core i5-3350P @ 3.1GHz - 16 GB RAM - NVIDIA GeForce GTX 1050 Ti 4GB

  3. #13
    thinBasic MVPs kryton9's Avatar
    Join Date
    Nov 2006
    Location
    Naples, Florida & Duluth, Georgia
    Age
    68
    Posts
    3,865
    Rep Power
    405
    Petr, I downloaded zips of the repositories, so if you need to request to pull, go ahead, if it messes me up, I will be ok with backups.

    Michael thanks for letting me know you noticed similar behavior, this way I know it is not something on my end.
    Last edited by kryton9; 12-05-2017 at 22:17.
    Acer Notebook: Win 10 Home 64 Bit, Core i7-4702MQ @ 2.2Ghz, 12 GB RAM, nVidia GTX 760M and Intel HD 4600
    Raspberry Pi 3: Raspbian OS use for Home Samba Server and Test HTTP Server

  4. #14
    Super Moderator Petr Schreiber's Avatar
    Join Date
    Aug 2005
    Location
    Brno - Czech Republic
    Posts
    7,153
    Rep Power
    736
    Kent,

    I restarted the Git client and the problem is gone! So I could prepare pull request for you, here:
    https://github.com/kryton9/thinBasic-cVec/pull/1

    It basically keeps the same functionality (unit tests are passing) while reducing code complexity.


    Petr
    Learn 3D graphics with ThinBASIC, learn TBGL!
    Windows 10 64bit - Intel Core i5-3350P @ 3.1GHz - 16 GB RAM - NVIDIA GeForce GTX 1050 Ti 4GB

  5. #15
    thinBasic MVPs kryton9's Avatar
    Join Date
    Nov 2006
    Location
    Naples, Florida & Duluth, Georgia
    Age
    68
    Posts
    3,865
    Rep Power
    405
    Quote Originally Posted by Petr Schreiber View Post
    Kent,

    I restarted the Git client and the problem is gone! So I could prepare pull request for you, here:
    https://github.com/kryton9/thinBasic-cVec/pull/1

    It basically keeps the same functionality (unit tests are passing) while reducing code complexity.


    Petr
    Thanks Petr, superb job. Really cleaned it up, thanks so much!
    Acer Notebook: Win 10 Home 64 Bit, Core i7-4702MQ @ 2.2Ghz, 12 GB RAM, nVidia GTX 760M and Intel HD 4600
    Raspberry Pi 3: Raspbian OS use for Home Samba Server and Test HTTP Server

Page 2 of 2 FirstFirst 12

Similar Threads

  1. is this example destinated for a class for converting into thinbasic?
    By largo_winch in forum Modules specific issues
    Replies: 4
    Last Post: 05-02-2013, 19:43
  2. 3D Vector Math include file.
    By D.J.Peters in forum Math scripts
    Replies: 5
    Last Post: 11-03-2010, 08:02
  3. OpenCL: Vector Add [Updated Sep 04 2011]
    By Petr Schreiber in forum OpenCL
    Replies: 14
    Last Post: 09-02-2010, 10:33
  4. Vector Graphics
    By Pipes in forum TBGL General
    Replies: 21
    Last Post: 31-08-2009, 20:44
  5. Example: passing vector or array to same function
    By e90712 in forum Math scripts
    Replies: 2
    Last Post: 19-07-2008, 00:33

Members who have read this thread: 0

There are no members to list at the moment.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •